Added from_url method to fetch evaluation annotation from the api. #1795
+214
−24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Made some optimizations.
dosubot
bot
added
the
size:L
renamed the fn from_url to from_ragas_platform
jjmachan
approved these changes
Dec 27, 2024
src/ragas/dataset_schema.py
Outdated
| return cls._process_dataset(dataset, metric_name) | ||
|
|
||
| @classmethod | ||
| def from_ragas_platform( |
There was a problem hiding this comment.
this brings to the point about what we are calling the thing at app.ragas.io - IMO is should be Ragas App and so the method should be from_ragas_app
There was a problem hiding this comment.
from_app is what I have named it right now, in case we need to be explicit, lets call it from_ragas_app
improve error handling in api responses with debug info enhance metric training with multiple data sources including run_id renamed the from_ragas_platform to from_app
shahules786
approved these changes
Jan 1, 2025
jjmachan
reviewed
Jan 8, 2025
src/ragas/dataset_schema.py
Outdated
| @@ -626,19 +626,16 @@ def from_json(cls, path: str, metric_name: t.Optional[str]) -> "MetricAnnotation | |||
| @classmethod | |||
| def from_app( | |||
| cls, | |||
| run_id: t.Optional[str] = None, | |||
| evaluation_result: t.Optional[EvaluationResult] = None, | |||
| run_id: str = None, | |||
There was a problem hiding this comment.
this will cause a type error since None is not an str type. The best way is to not have a default arg
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added from_url method to fetch evaluation annotation from the api.
Made some optimizations.